-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for graph.RO_QUERY command #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- see comments
- please add the RO API also to the transactions
- I think that we need dedicated test functions for RO API instead of mixing with the current tests, which are messy
src/main/java/com/redislabs/redisgraph/impl/api/AbstractRedisGraph.java
Outdated
Show resolved
Hide resolved
Co-authored-by: DvirDukhan <dvir@redislabs.com>
…disGraph into graph.ro_query
Will RO api work with read only slaves? Looks like JRedisGraph/src/main/java/com/redislabs/redisgraph/impl/graph_cache/GraphCacheList.java Line 53 in ed0c37c
JRedisGraph/src/main/java/com/redislabs/redisgraph/impl/api/AbstractRedisGraph.java Line 112 in ed0c37c
QUERY command instead of RO_QUERY command. I am not sure if this will be taken care in this PR.
|
src/main/java/com/redislabs/redisgraph/impl/api/ContextedRedisGraph.java
Outdated
Show resolved
Hide resolved
@tanvirp Do you have a solution in mind? Feel free to craft a PR. |
This PR kicks off the support for graph.RO_QUERY command by introducing queryReadOnly(). It includes the same api methods that query() offers.